I think some of the e2e tests have a valid failure here.

But, I believe at least for cmd + i the current behavior is to insert at the cursor location rather than add the line as context. I think this would also break the ability to toggle open/close the sidebar using cmd + L.

Is your main thought here that Copilot behaves in the way you showed in that video?

cc @sestinj for a second opinion on behavior.

Chatted this over with @sestinj

• We'd like to preserve the cmd + L sidebar toggling behavior
• We'd like to preserve cmd + I insert behavior, but only on empty lines.

With that in mind, could we scope the update to basically be "if the user pressed cmd + I on a line with any characters, the entire line is added to context` ?

So from what I can see, the existing Cmd+L behavior is to show the webview if hidden, and focus the cursor there. Not sure it's accurate to call it toggle, since another Cmd+L doesn't hide it, but the webview is unfocused.

I can look into reducing the scope of Cmd+I, I'll see if it works

Not sure it's accurate to call it toggle, since another Cmd+L doesn't hide it, but the webview is unfocused.

Hm, this isn't working for you? For me if I repeatedly hit Cmd + L it will open/close the sidebar.

I merged main but I believe the remaining failures are legitimate.

So actually the bulk of these changes concerns selecting the whole line on Cmd+L.

For Cmd+I, the only thing that changed was the command is now visible when right-clicking on the editor (removing the editorHasSelection clause for continue.focusEdit in package.json). The behavior of Cmd+I itself has not changed.

If the new Cmd+L behavior is not something the Continue team is willing to get in, this is fine, we can just reject this PR. But if you find some value in this approach, then I'll look more closely into the test failures, as expectations have changed.

@Patrick-Erichsen Let me know what you decide.

Not sure it's accurate to call it toggle, since another Cmd+L doesn't hide it, but the webview is unfocused.

Hm, this isn't working for you? For me if I repeatedly hit Cmd + L it will open/close the sidebar.

No it doesn't work for me that way. 2nd Cmd+L doesn't close the sidebar, just unfocusses it. I tried woth both release and prerelease versions of continue, on 2 macbooks.

Hm, well the cmd + L toggle behavior not working is a bug, that is the intended behavior.

But if the cmd + I behavior remains the same and the bulk of the changes are around the cmd + L line highlight then I think we can close this out, unfortunately. I don't think we have metrics on how many people actually use the toggle behavior so it's more of a "gut feel" but at least on the team most of use the toggle behavior quite frequently.

@fbricon circling back here, chatted things over more with @TyDunn and I think we'd be opening to aligning with Copilot here, eg having cmd + L add the current line.

I think it's likely that the only folks using the toggle behavior is the internal Continue team.

ok, I'll take a look at the test failures when I'm back from PTO on Monday

Think a few are still failing unfortunately

Yes, it was a simple rebase. I need to figure out how to run those tests locally

@fbricon after sitting on this for a while we're thinking it should add the whole file, since in most cases during usage the user will want to just add the file to context, and one line is rarely useful/probably usually confusing to the model. Thoughts on tweaking to add full file instead of that line?

Agree that removing the sidebar toggle functionality is fine